Review Request 122576: Introduce KMoreTools

[Albert Astals Cid]

> On feb. 22, 2015, 1:52 p.m., Albert Astals Cid wrote:
> > src/kmoretools/kmoretoolsconfigdialog.h, line 27
> > <https://git.reviewboard.kde.org/r/122576/diff/4/?file=350011#file350011line27>
> >
> >     Why is a non private header including a private header?
> 
> Gregor Mi wrote:
>     kmoretoolsconfigdialog.h should be private, too. How is this expressed? Also with adding a "_p" to the .h filename (and also to the .cpp filename?)?

Well you have "_p.h" in the other private headers too, so it makes sense to be consistent. Also make sure you don't install it :)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review76422
-----------------------------------------------------------


On feb. 16, 2015, 11:05 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122576/
> -----------------------------------------------------------
> 
> (Updated feb. 16, 2015, 11:05 p.m.)
> 
> 
> Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/
> 
> Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework
> 
> If KMoreTools is considered useful it needs a home. I placed it in KService for now.
> 
> 
> Diffs
> -----
> 
>   tests/kmoretools/kmoretoolstest.cpp PRE-CREATION 
>   tests/kmoretools/1/b.desktop PRE-CREATION 
>   tests/kmoretools/1/c.desktop PRE-CREATION 
>   tests/kmoretools/2/kate.desktop PRE-CREATION 
>   tests/kmoretools/2/kate.png PRE-CREATION 
>   tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION 
>   tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION 
>   CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 
>   src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 
>   src/kmoretools/kmoretools.h PRE-CREATION 
>   src/kmoretools/kmoretools.cpp PRE-CREATION 
>   src/kmoretools/kmoretools_p.h PRE-CREATION 
>   src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION 
>   src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION 
>   src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION 
>   tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e 
>   tests/kmoretools/1/a.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122576/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150222/a64deb42/attachment-0001.html>