Review Request 122654: Rework PSD plugin.

Alex Merry alex.merry at kde.org
Fri Feb 20 23:16:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122654/
-----------------------------------------------------------

Review request for KDE Frameworks and Alex Merry.


Repository: kimageformats


Description
-------

It now theoretically supports reading almost all PSD and PSB files, with the major exception of ones with 32-bit-per-channel colour. However, the code is almost entirely untested, due to me not having access to Photoshop.

As a result this is semi-speculative (I could commit it and hope for bug reports, but I'd rather test it properly).


Diffs
-----

  src/imageformats/lab_colorspace_p.h PRE-CREATION 
  src/imageformats/psd.cpp 394a339b39b9ba4b0e6046ee827e836934143ebc 
  src/imageformats/psd.json 859eede624d7637a0e613cd05a06d337fe39c139 
  src/imageformats/psd_p.h 7a1f51cb46d736d210db604eca762c092b709c63 
  src/imageformats/rle_p.h 04e795bf8770f40d79814a76dba2cfcbc6548a9c 

Diff: https://git.reviewboard.kde.org/r/122654/diff/


Testing
-------

Not enough (although the existing unit test passes).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150220/4897dffe/attachment.html>


More information about the Kde-frameworks-devel mailing list