Review Request 122650: Make PSD image reader endianess-agnostic.

[Dmitry Shachnev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122650/#review76347
-----------------------------------------------------------

Ship it!


As I was not able to get the new version of `long-runs.pic` (because it's binary file), I applied only the `psd.cpp` and `rle_p.h` parts of the patch (but not `pic.cpp`).

With these changes, the whole testsuite now succeeds on powerpc. There are also no regressions on amd64, arm64, i386 and ppc64el.

Thanks!

- Dmitry Shachnev


On Feb. 20, 2015, 6:14 nachm., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122650/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 6:14 nachm.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> By using the same strategy as the SoftImage PIC handler (and sharing
> some code with it), we should avoid reading the image data incorrectly
> on big-endian architectures.
> 
> 
> Diffs
> -----
> 
>   autotests/pic/long-runs.pic 99623e03c42df5a2c0902454d91bdbce911e5731 
>   src/imageformats/pic.cpp dc4dc8717911d36587751ef9300a120b34283f8e 
>   src/imageformats/psd.cpp c1e13b9a295c2c74b55e87c817491f90a4b667c2 
>   src/imageformats/rle_p.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122650/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150220/e436ff53/attachment.html>