Review Request 122642: an include is not correct

Aleix Pol Gonzalez aleixpol at kde.org
Thu Feb 19 23:02:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122642/#review76318
-----------------------------------------------------------


This shouldn't make a difference. Something else must have changed.

- Aleix Pol Gonzalez


On Feb. 19, 2015, 7:11 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122642/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2015, 7:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> trying to compile frameworks/kservice/src/services/kserviceaction.cpp
> I get:
> /usr/local/include/KF5/KCoreAddons/kpluginfactory.h:25:10: fatal error: 'kcoreaddons_export.h' file not found
> fatal error: 'kcoreaddons_export.h' file not found#include "kcoreaddons_export.h"
> 
> I propose to change it to
> #include <kcoreaddons_export.h>
> 
> 
> Diffs
> -----
> 
>   src/lib/plugin/kpluginfactory.h d2ffbdd22c8cbd553f74e11d0499dbf97adc28b5 
> 
> Diff: https://git.reviewboard.kde.org/r/122642/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150219/b87c4b64/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list