Review Request 122549: Avoid code path that leaves local config files locked

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122549/
-----------------------------------------------------------

(Updated Feb. 19, 2015, 10:49 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Matthew Dawson.


Repository: kconfig


Description
-------

The local config file gets locked on line 415, if we return early we
need to unlock it otherwise we keep a stray .lock file on the config.


----

We've been getting a lot of lockups in Plasma with stray .lock files so I code reviewed the relevant bit of code to look for any problems. I doubt this is the cause but it seems wrong anyway.


Diffs
-----

  src/core/kconfig.cpp 782e971 

Diff: https://git.reviewboard.kde.org/r/122549/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150219/cc6ad31b/attachment.html>