Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Wed Feb 18 16:28:14 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122616/#review76244
-----------------------------------------------------------



src/widgets/kpropertiesdialog.cpp
<https://git.reviewboard.kde.org/r/122616/#comment52568>

    memo: set "Unknown size" as text


- Emmanuel Pescosta


On Feb. 18, 2015, 9:17 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122616/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 9:17 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Use KIO::FileSystemFreeSpaceJob to retrieve free space information in KPropertiesDialog, this change enables KPropertiesDialog to show free space information of remote file systems as well (e.g. smb)
> 
> When the free space job failed "Unknown size" will be shown (same behavior as in Dolphin)
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.cpp 0dc4881 
>   src/widgets/kpropertiesdialog_p.h 5858eed 
> 
> Diff: https://git.reviewboard.kde.org/r/122616/diff/
> 
> 
> Testing
> -------
> 
> Works for local and smb file systems
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150218/803884c9/attachment.html>


More information about the Kde-frameworks-devel mailing list