Review Request 122614: Fix a porting bug in the http ioslave
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Wed Feb 18 08:11:50 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122614/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 9:11 a.m.)
Review request for KDE Frameworks.
Changes
-------
Add screenshot of fixed version
Repository: kio
Description
-------
Fix the file/directory name extraction + base dir handling in the http ioslave
"name" was always empty for directories because thisURL ends with a slash and fileName() will return an empty string, so href.text() was used as UDS_NAME instead.
Diffs
-----
src/ioslaves/http/http.cpp 78f50f9
Diff: https://git.reviewboard.kde.org/r/122614/diff/
Testing
-------
Works (see screenshots)
File Attachments (updated)
----------------
Webdav (Bug)
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/d0ae2572-3770-4781-88e3-4d40e626fd85__webdav_bug.png
Webdav (Fixed)
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/de96eb2e-45d8-4388-83b6-77199f677c75__webdav_fixed.png
Thanks,
Emmanuel Pescosta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150218/ae82fb77/attachment.html>
More information about the Kde-frameworks-devel
mailing list