Making prison a framework
Ivan Čukić
ivan.cukic at kde.org
Tue Feb 17 17:42:31 UTC 2015
Welcoming prison to the family of KDE Frameworks :)
A few nit-picks, in no particular order:
- & and * should not be touching the types, but the variables
(https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Whitespace)
- braces for functions should be on separate lines
(https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Braces)
- Any reason the d-ptr is not a constant pointer (Private *const d;)?
Or const QScopedPointer<Private> d (for auto-deletion)?
- declaring a function both as virtual and Q_DECL_OVERRIDE might be
frowned upon by some people (IIRC Albert)
- there are trailing spaces in a few places
- Indentation for kdelibs should be 4 spaces, no tabs (tabs are
present at least in datamatrixbarcode.cpp)
(https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Indentation)
- If this gets compiled with exceptions enabled, there is a
possibility of resource leakage (new [] and delete []). Though, I'm
guessing that if things here do throw, those will be serious enough to
terminate the program, so the leak would not be even noticed. :)
- d(0) should be d(Q_NULLPTR)
- other style issues.
Cheerio,
Ivan
KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/
gpg key id: 850B6F76, keyserver.pgp.com
More information about the Kde-frameworks-devel
mailing list