Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Feb 17 17:04:33 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122608/#review76195
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 17, 2015, 3:51 p.m., Olivier Goffart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122608/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 3:51 p.m.)
>
>
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
>
>
> Repository: kiconthemes
>
>
> Description
> -------
>
> Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
>
> because KIconEngine::availableSize always return something even if the icon
> is not there
>
> BUG: 342906
>
>
> Diffs
> -----
>
> src/kiconengine.cpp 530403e
>
> Diff: https://git.reviewboard.kde.org/r/122608/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Olivier Goffart
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150217/a608dc5d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list