Review Request 122498: Register with dbus to wake up KRun, and unregister then

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122498/
-----------------------------------------------------------

(Updated Feb. 16, 2015, 9:08 p.m.)


Review request for Kate and KDE Frameworks.


Changes
-------

Fix the HAVE_X11 usage. I've removed it altogether as KStartupInfo has implementations for all platforms (mostly stubs but still) and Kate depends on relatively new KF (5.6).

I didn't go for the X-DBUS-StartupType=None fix as I really don't know if Kate or any other part of the app execution process requires it for anything or not.


Repository: kate


Description
-------

This is the patch from bug 339094. As it seemes there's no response/activity to that, I just put it here for proper review (and will commit on behalf of Liu Zhe obviously) as this is really annoying bug. Following is the description by Liu:

Documentation of KToolInvocation (called by KRun when click a file in dolphin) said "Multi" means "Always start a new service, wait until the service has registered with D-Bus". But when the second text file is opened, kate just starts a QApplication and waits, without registering with DBus.
In KDE 4, the second instance of kate launchs an empty KApplication to do this job, but the author said "it's too bad" to register a service. Maybe we can register to make KService happy and unregister at once.
Another problem is that the kate icon will jump quite a few seconds after clicking the second file. I thought the reason was KStartupInfo::appStarted() not called as it requires Q_WS_X11 macro, which is not defined in Qt 5. But the bug still exists after I fixed this.


Diffs (updated)
-----

  kate/src/kateapp.cpp 4c26f33 
  kate/src/main.cpp 8852754 

Diff: https://git.reviewboard.kde.org/r/122498/diff/


Testing
-------

Hrvoje confirmed in the bug report that this indeed fixes the issue.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150216/a0ec6b37/attachment-0001.html>