Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/
-----------------------------------------------------------

(Updated Feb. 16, 2015, 6:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, and Thiago Macieira.


Repository: kconfig


Description
-------

The if statements at lines 84, 91
if (path.startsWith(dir) + '/') {
cannot be correct. The value of (path.startsWith(dir) + '/') is always 47.

I propose to use:
    QString plus = QLatin1String("/");
    QString dirPlus;
...
     Q_FOREACH (...) {
        dirPlus = dir;
        dirPlus.append(plus);
        if (path.startsWith(dirPlus)) {


Diffs
-----

  src/core/kdesktopfile.cpp 6381cb30ba9382de492e2d8d4cf1f9e342f1c509 

Diff: https://git.reviewboard.kde.org/r/122445/diff/


Testing
-------


Thanks,

Guy Maurel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150216/0d09e1d7/attachment.html>