Review Request 122590: Guard kglobalaccel against QApplication

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122590/
-----------------------------------------------------------

(Updated Feb. 16, 2015, 12:25 nachm.)


Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.


Changes
-------

Drop widget stuff and use lambda

Compiles but not really tested (shortcuts still work though), no idea when that would be triggered


Repository: kglobalaccel


Description
-------

KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it.


Diffs (updated)
-----

  src/kglobalaccel.h 4a5595f 
  src/kglobalaccel.cpp df85547 
  src/kglobalaccel_p.h b1528dc 

Diff: https://git.reviewboard.kde.org/r/122590/diff/


Testing
-------

screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150216/de865d30/attachment.html>