Review Request 122562: Add method for converting from QVariant to base64

Vishesh Handa me at vhanda.in
Mon Feb 16 12:05:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122562/#review76118
-----------------------------------------------------------



src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp
<https://git.reviewboard.kde.org/r/122562/#comment52519>

    Coding style



src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp
<https://git.reviewboard.kde.org/r/122562/#comment52520>

    huh?
    
    The `case QVariant::String` does not matter.


- Vishesh Handa


On Feb. 13, 2015, 6:16 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122562/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 6:16 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> I need some method like that over at the QuickShare plasmoid.
> 
> I'm unsure where to put it, anybody knows of a good place?
> Otherwise I guess it works fine with the clipboard, that returns QVariant.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp 23ce29b 
>   src/qmlcontrols/kquickcontrolsaddons/clipboard.h ac89b9d 
> 
> Diff: https://git.reviewboard.kde.org/r/122562/diff/
> 
> 
> Testing
> -------
> 
> Adopted locally in my QuickShare plasmoid implementation
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150216/44e50a27/attachment.html>


More information about the Kde-frameworks-devel mailing list