Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

Àlex Fiestas afiestas at kde.org
Sun Feb 15 18:27:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121447/
-----------------------------------------------------------

(Updated Feb. 15, 2015, 6:27 p.m.)


Review request for KDE Frameworks.


Changes
-------

Add tests for a case suggested by dfaure


Repository: kio


Description
-------

If we know that the item is a dir, return directly the correct mimetype for directories.

More info of why this is needed at:
https://git.reviewboard.kde.org/r/120909/


Diffs (updated)
-----

  autotests/kfileitemtest.h 0ee7204 
  autotests/kfileitemtest.cpp 59c104e 
  src/core/kfileitem.cpp 5894226 

Diff: https://git.reviewboard.kde.org/r/121447/diff/


Testing
-------

Besides tests, tried smb kioslave and it worked great.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150215/6b25dec3/attachment.html>


More information about the Kde-frameworks-devel mailing list