Review Request 122484: KCodecs: Fix i18n of character set names

David Faure faure at kde.org
Sat Feb 14 10:28:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122484/#review76016
-----------------------------------------------------------


Why not actually specify a context, for instance "KCharsets"?

- David Faure


On Feb. 8, 2015, 9:16 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122484/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2015, 9:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcodecs
> 
> 
> Description
> -------
> 
> Fix i18n of character set names
> 
> Now the translate calls match what is extracted into catalogs.
> 
> For these translate calls to work with qm files generated by ecm_process_po_files_as_qm, the following Qt bug needs to be fixed: https://bugreports.qt.io/browse/QTBUG-44362
> 
> 
> Diffs
> -----
> 
>   src/kcharsets.cpp 83a461b 
> 
> Diff: https://git.reviewboard.kde.org/r/122484/diff/
> 
> 
> Testing
> -------
> 
> Manual testing with KWrite and Konversation that use these functions, using qm files generated with lrelease without -compress option.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150214/6b52f641/attachment.html>


More information about the Kde-frameworks-devel mailing list