Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

[Jeremy Whiting]

> On Feb. 13, 2015, 5:11 a.m., Martin Klapetek wrote:
> > src/notifybyspeech.cpp, line 65
> > <https://git.reviewboard.kde.org/r/122555/diff/1/?file=348637#file348637line65>
> >
> >     Is there any way to know when the say() has finished? Because the finished() below will delete the notification object if it's the only plugin, which may just interrupt the speech in the middle

We could watch the tts object for state change, but we wouldn't know which speech job it's finishing. Anyway, I don't think it matters, we pass the text to speak then the knotification object can get deleted with no effect on the speech itself from what I've heard (with my ears, not through the grape vine).


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122555/#review75986
-----------------------------------------------------------


On Feb. 12, 2015, 8:11 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122555/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 8:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Frederik Gladhorn.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Add optional dependency on Qt5TextToSpeech for speech notifications.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd 
>   src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9 
>   src/knotification.h c85621699793436442090b7f94ea82ef10c45b89 
>   src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9 
>   src/kstatusnotifieritem.h 113dad513c320ef97f59b221b3541ca2f388693e 
>   src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542 
>   src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1 
>   src/notifybyspeech.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122555/diff/
> 
> 
> Testing
> -------
> 
> As I said in the knotifyconfig review something at runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available.
> 
> QtSpeech is still in development, so this change is added as an optional dependency.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150213/3bcadc43/attachment.html>