Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

Jeremy Whiting jpwhiting at kde.org
Fri Feb 13 03:11:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122555/
-----------------------------------------------------------

Review request for KDE Frameworks and Frederik Gladhorn.


Repository: knotifications


Description
-------

Add optional dependency on Qt5TextToSpeech for speech notifications.


Diffs
-----

  CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd 
  src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9 
  src/knotification.h c85621699793436442090b7f94ea82ef10c45b89 
  src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9 
  src/kstatusnotifieritem.h 113dad513c320ef97f59b221b3541ca2f388693e 
  src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542 
  src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1 
  src/notifybyspeech.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122555/diff/


Testing
-------

As I said in the knotifyconfig review something at runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available.

QtSpeech is still in development, so this change is added as an optional dependency.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150213/8ae80ab3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list