Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122554/
-----------------------------------------------------------

Review request for KDE Frameworks and Frederik Gladhorn.


Repository: knotifyconfig


Description
-------

Change config from KTTS to Speech.
If QtSpeech is available when building return true from have_speech static method.
Otherwise return false.
Could also add a check to see if there are any backend errors later on.


Diffs
-----

  CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 
  src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 
  src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 
  src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 
  src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 
  src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b 
  src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 

Diff: https://git.reviewboard.kde.org/r/122554/diff/


Testing
-------

It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken.

Something strange here:
After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case).
Similarly, after disabling this notification, messages are still spoken until restarting the application.
I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150213/392126b1/attachment.html>