Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

[Albert Astals Cid]

> On feb. 12, 2015, 4:43 p.m., Albert Astals Cid wrote:
> > It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not needed since final will already complain if trying to "finalize" something that is not overriding a virtual of the parent, no?
> 
> Kevin Funk wrote:
>     Nitpicker! :D
>     
>     Fixed that one occurence, but won't upload the patch again.

Honestly, if it compiles, ship it, you can't screw up.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122542/#review75928
-----------------------------------------------------------


On feb. 12, 2015, 3:47 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122542/
> -----------------------------------------------------------
> 
> (Updated feb. 12, 2015, 3:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This is a huge patch (almost 30 000 lines) covering all frameworks.
> 
> This was done using clang-modernize and a few wrapper scripts.
> 
> If you'll give me the okay, I'll push this to the individual frameworks.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/122542/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine on my machine.
> 
> 
> File Attachments
> ----------------
> 
> frameworks-add-override.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch
> Without 'virtual'
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150212/4fb2fab4/attachment.html>