Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
Ivan Čukić
ivan.cukic at kde.org
Thu Feb 12 15:12:16 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122542/#review75926
-----------------------------------------------------------
+1 from me (though it would be prettier to also remove 'virtual', as Albert mentioned)
- Ivan Čukić
On Feb. 12, 2015, 2:43 p.m., Kevin Funk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122542/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 2:43 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> This is a huge patch (almost 30 000 lines) covering all frameworks.
>
> This was done using clang-modernize and a few wrapper scripts.
>
> If you'll give me the okay, I'll push this to the individual frameworks.
>
>
> Diffs
> -----
>
>
> Diff: https://git.reviewboard.kde.org/r/122542/diff/
>
>
> Testing
> -------
>
> Compiles fine on my machine.
>
>
> File Attachments
> ----------------
>
> frameworks-add-override.patch
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch
>
>
> Thanks,
>
> Kevin Funk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150212/ef2bc0fa/attachment.html>
More information about the Kde-frameworks-devel
mailing list