Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Feb 12 13:54:34 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122514/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 1:54 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Alex Richardson and David Faure.
Repository: kservice
Description
-------
Currently it checks whether it's a stringlist value according to the servicetype (good) and splits the ','.
What this patch does is to allow plugins to use json lists to specify string list properties. For example:
"X-KDevelop-Interfaces": [ "IBuildSystemManager", "IProjectFileManager"]
Otherwise I was getting invalid values and nothing worked.
Diffs
-----
autotests/kplugininfotest.cpp d99b92a
src/services/kplugininfo.cpp 572f14b
Diff: https://git.reviewboard.kde.org/r/122514/diff/
Testing
-------
Builds, tests still pass.
Now KDevelop boots correctly, I tried to add a test, but I don't know where's the service type file for "KService/NSA".
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150212/5d8580f7/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list