Review Request 122539: Use Q_DECL_OVERRIDE where possible

Kevin Funk kfunk at kde.org
Wed Feb 11 23:20:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122539/#review75893
-----------------------------------------------------------


Note: I can easily script this to run on all frameworks. Please tell me if it's desired and I'll go ahead.

- Kevin Funk


On Feb. 11, 2015, 11:19 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122539/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 11:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> With -Winconsistent-missing-override (Clang), headers from KConfig are
> throwing a lot of warnings.
> 
> 
> Diffs
> -----
> 
>   src/core/kconfig.h 0fb15756ec9d089b956ebc9eb3eeade0a76cf7c1 
>   src/core/kconfiggroup.h abb246e37619bcead938a0496eac51f6afff5ec4 
>   src/core/kconfigini_p.h 29f61090df99bf66fdccdb0a1801dbeaec1c6c0f 
>   src/core/kcoreconfigskeleton.h bb3d0f61adbfe95077fce759bb437ae7a13856be 
>   src/core/ksharedconfig.h b2317afd6d5189e6364acc989bc9ca7a5694248d 
>   src/gui/kconfigloader.h aadb19a5b266f4c1ccd07d4b05af0dcbd2686bd9 
>   src/gui/kconfigloaderhandler_p.h 1c7c5a1d3c79a7e98a53245d1037be0b253dc135 
>   src/gui/kconfigskeleton.h 4cd8d140535bb550af8b934a746e2a8ffc0ec008 
> 
> Diff: https://git.reviewboard.kde.org/r/122539/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150211/bcabd0fc/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list