Review Request 122526: Add Debian path to search for qtwaylandscanner

Aleix Pol Gonzalez aleixpol at kde.org
Wed Feb 11 13:54:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122526/#review75852
-----------------------------------------------------------



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/122526/#comment52364>

    You want to use HINTS instead of PATHS.
    
    Also wouldn't it make sense to have QtWayland exporting the scanner as a target?


- Aleix Pol Gonzalez


On Feb. 11, 2015, 2:39 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122526/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 2:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add Debian path to search for qtwaylandscanner
> 
> Debian likes to install qt binaries into an obscure path, search here as well
> 
> 
> Diffs
> -----
> 
>   find-modules/FindQtWaylandScanner.cmake 28a4fda 
> 
> Diff: https://git.reviewboard.kde.org/r/122526/diff/
> 
> 
> Testing
> -------
> 
> made a cmakelists.txt files to search for qtwaylandscanner. It successfully finds qtwaylandscanner when in /usr/bin/ and when in the debian path
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150211/5d7528d5/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list