Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

[Àlex Fiestas]

> On feb. 9, 2015, 7:24 p.m., David Faure wrote:
> > This should not be done if the slave has provided a UDS_MIME_TYPE. E.g. kio_smb sends mimetypes that derive from inode/directory, such as application/x-smb-server and application/x-smb-workgroup. If you think this works with the current patch, please prove it with a unittest :-)
> 
> Àlex Fiestas wrote:
>     I quite not get this message sorry :/ can you explain a bit more?

Mmm I think I get it now, will check it out (write the test) tomorrow.


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121447/#review75730
-----------------------------------------------------------


On feb. 9, 2015, 5:51 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121447/
> -----------------------------------------------------------
> 
> (Updated feb. 9, 2015, 5:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> If we know that the item is a dir, return directly the correct mimetype for directories.
> 
> More info of why this is needed at:
> https://git.reviewboard.kde.org/r/120909/
> 
> 
> Diffs
> -----
> 
>   autotests/kfileitemtest.h 0ee7204 
>   autotests/kfileitemtest.cpp 59c104e 
>   src/core/kfileitem.cpp 5894226 
> 
> Diff: https://git.reviewboard.kde.org/r/121447/diff/
> 
> 
> Testing
> -------
> 
> Besides tests, tried smb kioslave and it worked great.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150209/73f84de2/attachment.html>