Review Request 121447: Return inode/directory when isDir returns true (kfileitem)
Mark Gaiser
markg85 at gmail.com
Mon Feb 9 18:49:44 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121447/#review75726
-----------------------------------------------------------
+1
- Mark Gaiser
On feb 9, 2015, 5:51 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121447/
> -----------------------------------------------------------
>
> (Updated feb 9, 2015, 5:51 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> If we know that the item is a dir, return directly the correct mimetype for directories.
>
> More info of why this is needed at:
> https://git.reviewboard.kde.org/r/120909/
>
>
> Diffs
> -----
>
> autotests/kfileitemtest.h 0ee7204
> autotests/kfileitemtest.cpp 59c104e
> src/core/kfileitem.cpp 5894226
>
> Diff: https://git.reviewboard.kde.org/r/121447/diff/
>
>
> Testing
> -------
>
> Besides tests, tried smb kioslave and it worked great.
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150209/7e3e0c9d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list