Review Request 122493: Use qRound rather than C++11 std::lround.

Ivan Čukić ivan.cukic at kde.org
Mon Feb 9 17:59:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122493/#review75719
-----------------------------------------------------------

Ship it!


Seems ok to me

- Ivan Čukić


On Feb. 9, 2015, 3:31 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122493/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 3:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Use qRound rather than C++11 std::lround.
> 
> Removes dependency on C++11.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 67ce63a943234b167165b0f3986f974bba5ff0cf 
> 
> Diff: https://git.reviewboard.kde.org/r/122493/diff/
> 
> 
> Testing
> -------
> 
> kdeclarative is able to build on OS X 10.7 with the built in XCode compiler and standard library.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150209/936908e0/attachment.html>


More information about the Kde-frameworks-devel mailing list