Review Request 122495: CMake nitpicking on KDiagram

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122495/#review75704
-----------------------------------------------------------

Ship it!


Ship It!

- Friedrich W. H. Kossebau


On Feb. 9, 2015, 3:09 vorm., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122495/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 3:09 vorm.)
> 
> 
> Review request for KDE Frameworks and Friedrich W. H. Kossebau.
> 
> 
> Repository: kdiagram
> 
> 
> Description
> -------
> 
> Mark Qt5::Widgets public for both KCharts and KGantt.
> Remove SHARED from add_library, let cmake use the default (which is SHARED, but the user can configure).
> Fix some indentation.
> Remove redundant dependencies: if we depend on Qt5::Widgets, we're already pulling Qt5::Gui.
> 
> 
> Diffs
> -----
> 
>   src/KChart/CMakeLists.txt 06f3846 
>   src/KGantt/CMakeLists.txt 25d198f 
>   CMakeLists.txt 76a7c50 
> 
> Diff: https://git.reviewboard.kde.org/r/122495/diff/
> 
> 
> Testing
> -------
> 
> Still builds.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150209/783f33d5/attachment.html>