Review Request 122481: Fix use of environ for OS X

Jeremy Whiting jpwhiting at kde.org
Mon Feb 9 03:24:48 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122481/
-----------------------------------------------------------

(Updated Feb. 8, 2015, 8:24 p.m.)


Review request for KDE Frameworks, David Faure, Marko Käning, and René J.V. Bertin.


Changes
-------

Thanks for the idea, changed to use QProcessEnvironment.


Repository: kio


Description
-------

On OS X 10.7 environ needs to be #defined as _NSGetEnviron() from <crt_externs.h> according to man environ. This is also required for kio to build on OS X 10.7


Diffs (updated)
-----

  src/widgets/kurlcompletion.cpp 1871c49a936e2ca322286e23ad6fe976ae2c7044 

Diff: https://git.reviewboard.kde.org/r/122481/diff/


Testing
-------

kio builds with this patch on OS X 10.7 and 10.10


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150209/c201f900/attachment.html>


More information about the Kde-frameworks-devel mailing list