Review Request 122482: Restore KCModule::setAuthAction

Aleix Pol Gonzalez aleixpol at kde.org
Sun Feb 8 17:16:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122482/#review75617
-----------------------------------------------------------



src/kcmodule.cpp
<https://git.reviewboard.kde.org/r/122482/#comment52293>

    else
    qWarning() << "invalid authorization"
    ?
    
    Or something?


- Aleix Pol Gonzalez


On Feb. 8, 2015, 5:25 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122482/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2015, 5:25 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> Sometimes we need our save action in our kconfig module to refer to a
> polkit action which is not in the format org.kde.kcontrol.name.save. For
> example I am making the clock KCM module call timedated directly without
> needing our helper.
> 
> Setting the right polkit action is needed for systemsettings to display
> the correct message of whether root priveldges will be needed.
> 
> This method is referred to in the documentation already so I assume this
> used to exist?
> 
> 
> Diffs
> -----
> 
>   src/kcmodule.h 4fb5e0d 
>   src/kcmodule.cpp 3c43649 
> 
> Diff: https://git.reviewboard.kde.org/r/122482/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150208/0bb77b3c/attachment.html>


More information about the Kde-frameworks-devel mailing list