Review Request 122478: KConfigWidgets: Remove leftover uses of tr() for translation
David Edmundson
david at davidedmundson.co.uk
Sun Feb 8 13:48:49 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122478/#review75600
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Feb. 8, 2015, 1:11 p.m., Lasse Liehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122478/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2015, 1:11 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> Remove leftover uses of tr() for translation
>
> KConfigWidgets uses KI18n and these strings were not even extracted.
>
> Just noticed this randomly today.
>
> Two tr() calls still remain in ktipdialog.cpp. Those translate the tips themselves. There is a bug report at https://bugs.kde.org/show_bug.cgi?id=343936.
>
>
> Diffs
> -----
>
> src/kconfigdialog.cpp 6214348
> src/ktipdialog.cpp bd3cbd3
>
> Diff: https://git.reviewboard.kde.org/r/122478/diff/
>
>
> Testing
> -------
>
> Strings still show up correctly in UI.
>
>
> Thanks,
>
> Lasse Liehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150208/a15719fa/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list