Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/#review75594
-----------------------------------------------------------



src/core/kdesktopfile.cpp
<https://git.reviewboard.kde.org/r/122445/#comment52286>

    a QChar would be enough



src/core/kdesktopfile.cpp
<https://git.reviewboard.kde.org/r/122445/#comment52284>

    in C++, better declare vars as close as possible to where they are used; this looks like C.



src/core/kdesktopfile.cpp
<https://git.reviewboard.kde.org/r/122445/#comment52285>

    path.startsWith(dir + plus) would be better (the temporary could be moved rather than copied, with C++11)


- David Faure


On Feb. 5, 2015, 6:36 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122445/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 6:36 p.m.)
> 
> 
> Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, and Thiago Macieira.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> The if statements at lines 84, 91
> if (path.startsWith(dir) + '/') {
> cannot be correct. The value of (path.startsWith(dir) + '/') is always 47.
> 
> I propose to use:
>     QString plus = QLatin1String("/");
>     QString dirPlus;
> ...
>      Q_FOREACH (...) {
>         dirPlus = dir;
>         dirPlus.append(plus);
>         if (path.startsWith(dirPlus)) {
> 
> 
> Diffs
> -----
> 
>   src/core/kdesktopfile.cpp 6381cb30ba9382de492e2d8d4cf1f9e342f1c509 
> 
> Diff: https://git.reviewboard.kde.org/r/122445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150208/39bfe811/attachment.html>