Review Request 122430: add optional properties rangeMax and rangeMin

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122430/#review75430
-----------------------------------------------------------



src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
<https://git.reviewboard.kde.org/r/122430/#comment52175>

    to match the docs this possibly wants a || autoRange
    
    otherwise it is having an effect; just not a very useful one.



src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
<https://git.reviewboard.kde.org/r/122430/#comment52176>

    we should call normalizeData here too?
    
    otherwise it won't have an effect until the next addSample()



src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
<https://git.reviewboard.kde.org/r/122430/#comment52178>

    does it makes sense to 
    
    if (autoRange)
    {
      if (m_rangeMax != adjustedMax) {
        m_rangeMax = adjustedMax
        emit autoMaxChanged()
      }
    }
    
    so that when it auto range mode you can retrieve the max and min from the API.



src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
<https://git.reviewboard.kde.org/r/122430/#comment52179>

    so if you're not in auto range and you set max to be the same as min we'd see the data is just the raw values, not even scaled to the height of the plot.
    
    Is that what we intend?


- David Edmundson


On Feb. 4, 2015, 5:07 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122430/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 5:07 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> To be used when autoRange is false, scales the values between two known max and min.
> so if for instance we know all the value coming will be percentage, we can ensure the height of the graph has the same proportion of the percentage compared to 100%
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.h 3a10212 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 1ea7fad 
> 
> Diff: https://git.reviewboard.kde.org/r/122430/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150204/963fe796/attachment-0001.html>