Review Request 122396: Fix knotifyconfig leak

[Martin Klapetek]

> On Feb. 3, 2015, 10:19 a.m., Martin Klapetek wrote:
> > src/knotifyconfig.h, line 93
> > <https://git.reviewboard.kde.org/r/122396/diff/2/?file=346533#file346533line93>
> >
> >     This should be appName really, the notifybypopup got it wrong :S But let's keep the public api consistent
> 
> Xuetian Weng wrote:
>     But there's already an appName(). Any other name you can think of?
>     
>     The reason that I move it here is because I saw eventsfile and configfile are marked as internal, so I don't want to provide access to them directly.

Aaah I see now. Ok, let's name it appConfigName, it's Name from Config after all.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122396/#review75271
-----------------------------------------------------------


On Feb. 3, 2015, 1:15 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122396/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 1:15 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> knotifyconfig in notify would not be free'd in many case. This patch pass const reference instead of pointer to plugin. And add a copy constructor to KNotifyConfig, so it's not possible to leak anymore.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 3e5821a 
>   src/knotificationmanager.cpp 3cf637c 
>   src/knotificationplugin.h 3438e7d 
>   src/knotifyconfig.h fae17cb 
>   src/knotifyconfig.cpp af6be92 
>   src/notifybyaudio.cpp d7090ac 
>   src/notifybypopup.h a605a77 
>   src/notifybypopup.cpp 2f08146 
> 
> Diff: https://git.reviewboard.kde.org/r/122396/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150203/cd5f6207/attachment.html>