Review Request 122408: allow to cycle through activities from global shortcuts plugin

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122408/#review75324
-----------------------------------------------------------


This does fix the switching, but I don't agree it is the right place for it (I don't like that this plugin exists at all tbh).

When switching the activities, there needs to be a (UI) feedback - the switcher needs to show up. That means either moving the switcher UI to this plugin (which I don't like), or having this in plasmashell.

- Ivan Čukić


On Feb. 3, 2015, 5:11 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122408/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 5:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Ivan Čukić.
> 
> 
> Bugs: 342186
>     http://bugs.kde.org/show_bug.cgi?id=342186
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> Currently shellcorona registeres those shortcuts but that is not right place and it is not working there, so this is place where this should be done
> 
> 
> Diffs
> -----
> 
>   src/service/plugins/globalshortcuts/GlobalShortcutsPlugin.h 54a24a8 
>   src/service/plugins/globalshortcuts/GlobalShortcutsPlugin.cpp 1a13b6b 
> 
> Diff: https://git.reviewboard.kde.org/r/122408/diff/
> 
> 
> Testing
> -------
> 
> alt+tab, alt+s works to cycle activities and stop activities but somehow alt+shift+tab is not working due to some kglobalaccel limitation.
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150203/6e922b17/attachment.html>