Review Request 122396: Fix knotifyconfig leak

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122396/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 12:15 a.m.)


Review request for KDE Frameworks and Martin Klapetek.


Changes
-------

remove abi/api change. and install knotifyconfig.h


Repository: knotifications


Description (updated)
-------

knotifyconfig in notify would not be free'd in many case. This patch pass const reference instead of pointer to plugin. And add a copy constructor to KNotifyConfig, so it's not possible to leak anymore.


Diffs (updated)
-----

  src/CMakeLists.txt 3e5821a 
  src/knotificationmanager.cpp 3cf637c 
  src/knotificationplugin.h 3438e7d 
  src/knotifyconfig.h fae17cb 
  src/knotifyconfig.cpp af6be92 
  src/notifybyaudio.cpp d7090ac 
  src/notifybypopup.h a605a77 
  src/notifybypopup.cpp 2f08146 

Diff: https://git.reviewboard.kde.org/r/122396/diff/


Testing
-------

Works.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150203/97e3753e/attachment.html>