Review Request 122300: Fix quoteArgs for spaces that are not the regular space

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122300/
-----------------------------------------------------------

(Updated Feb. 2, 2015, 10:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure, Eike Hein, and Michael Pyne.


Bugs: 343380
    https://bugs.kde.org/show_bug.cgi?id=343380


Repository: kcoreaddons


Description
-------

We need to also quote spaces like the Unicode character 'IDEOGRAPHIC SPACE' (U+3000) in KShell::quoteArg since KShell::splitArgs is using QChar::isSpace to decide when a new argument starts, without the quoting, one argument will get turned into two


Diffs
-----

  autotests/kshelltest.cpp 451bbe9 
  src/lib/util/kshell_unix.cpp e0e884f 

Diff: https://git.reviewboard.kde.org/r/122300/diff/


Testing
-------

New test passes, bug 343380 is fixed


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150202/a9fa3b3f/attachment-0001.html>