Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

Olivier Goffart ogoffart at kde.org
Wed Dec 30 08:08:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126568/#review90327
-----------------------------------------------------------

Ship it!


Ship It!

- Olivier Goffart


On Dez. 29, 2015, 10:58 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126568/
> -----------------------------------------------------------
> 
> (Updated Dez. 29, 2015, 10:58 nachm.)
> 
> 
> Review request for KDE Frameworks, Martin Klapetek and Olivier Goffart.
> 
> 
> Repository: knotifyconfig
> 
> 
> Description
> -------
> 
> This allows to programmatically select an event with a given Event ID (naming isn't really consistent here, sometimes it's event ID, sometimes event name).
> 
> In notifications we show a configure button that opens up the config dialog for that app; with this patch I can highlight the specific app that was just opened, so the user can disable/reconfigure exactly that one.
> 
> 
> Diffs
> -----
> 
>   src/knotifyconfigelement.h 6c6ed50 
>   src/knotifyconfigelement.cpp e306bd6 
>   src/knotifyconfigwidget.h 9c1bbfa 
>   src/knotifyconfigwidget.cpp 4653529 
>   src/knotifyeventlist.h 9d9804c 
>   src/knotifyeventlist.cpp 6046d2d 
> 
> Diff: https://git.reviewboard.kde.org/r/126568/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151230/5d723c73/attachment.html>


More information about the Kde-frameworks-devel mailing list