Review Request 126556: Ensure group is unescaped properly in kconf_update.

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126556/
-----------------------------------------------------------

(Updated Dec. 30, 2015, 12:35 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Matthew Dawson.


Changes
-------

Submitted with commit 55bf90ff787f4e84947a5df833f66082e54016df by Matthew Dawson to branch master.


Repository: kconfig


Description
-------

During a kconf_update run, an invalid group name may be treated as correct
even though the name failed to unescape.  This leads the group name to be
a null character, which will fail.

If the unescape failed, return that failure status instead.  This should have
no impact, as the previous result would have been wrong anyways.  Now a
more useful diagnostic will be returned instead.

Update the unit tests to ensure this issue is tested in the future.

Found in Coverity issue 258087.


Diffs
-----

  autotests/test_kconfigutils.cpp 0946cf8a89135e12c1769a3ab6749434aa9691ce 
  src/kconf_update/kconfigutils.cpp 02b3f0a9d245fdc9d0067635e9b59bc84eefc206 

Diff: https://git.reviewboard.kde.org/r/126556/diff/


Testing
-------

Unit tests pass after change, new test fails without code change.


Thanks,

Matthew Dawson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151230/c235daa5/attachment.html>