Review Request 125869: Convert all io slave .protocol data to json and embed it.
Christoph Cullmann
cullmann at kde.org
Mon Dec 28 19:25:31 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 7:25 p.m.)
Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David Faure, and Luigi Toscano.
Repository: kio
Description
-------
Convert all io slave .protocol data to json and embed it.
Allows easier deployment of the slaves.
Diffs
-----
src/core/kprotocolinfo.cpp 7bfb9ad
src/protocoltojson/main.cpp 05b9364
Diff: https://git.reviewboard.kde.org/r/125869/diff/
Testing
-------
Tests still work (one needed patching, as the exec line contains now the full path).
Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change.
File Attachments (updated)
----------------
trash.json
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json
Thanks,
Christoph Cullmann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151228/ac3bd459/attachment.html>
More information about the Kde-frameworks-devel
mailing list