Review Request 125869: Convert all io slave .protocol data to json and embed it.

Alex Richardson arichardson.kde at gmail.com
Mon Dec 28 17:20:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review90237
-----------------------------------------------------------


Could you post a patch with the JSON files? I'll look into implementing the translations then.

- Alex Richardson


On Dec. 27, 2015, 5:14 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2015, 5:14 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -----
> 
>   src/core/kprotocolinfo.cpp 7bfb9ad 
>   src/protocoltojson/main.cpp 05b9364 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> -------
> 
> Tests still work (one needed patching, as the exec line contains now the full path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151228/ab792c26/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list