Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126343/
-----------------------------------------------------------

(Updated Dec. 28, 2015, 4:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 218084df9f5266306045fc6876e8f0a6886808dd by Alex Richardson to branch master.


Repository: kcoreaddons


Description
-------

Add KPluginMetaData::translators() and KAboutPerson::fromJson()

Plugins could have a list of translators in KDE4 through KAboutData so
this commit restores this for KF5. As a side effect of now having
authors() and translators() returning a list of KAboutPerson I also
added KAboutPerson::fromJSON() as publc function but I can make that
internal API instead if it's preferred.

--- 

Add KPluginMetaData::copyrightText(), extraInformation() and otherContributors()

Now KPluginMetaData has well defined keys for all the information used
by KAboutData. This means we can easily create KAboutData objects from
a KPluginMetaData object e.g. for use in an KAboutApplicationDialog.
For example Okular uses this to display information about generator that
is being used for the current document.

---

Add KAboutData::fromPluginMetaData(const KPluginMetaData &plugin)

This is useful e.g. to create an KAboutApplicationDialog for plugins


Diffs
-----

  autotests/kpluginmetadatatest.cpp 25c8b8d5351eb5c5c784d528f9e90dfc8ea77982 
  src/lib/kaboutdata.h 0dbd7a0ce7ec9220614c5f824a0f379ea5f45559 
  src/lib/kaboutdata.cpp 5d9a55ea027fc1b8fb6e6394d72cf48f142bb664 
  src/lib/plugin/kpluginmetadata.h a91b94ad404b6839aa3b8d13b8da19f407708c1b 
  src/lib/plugin/kpluginmetadata.cpp 36743600788693b6449d065f0448e3195445772e 

Diff: https://git.reviewboard.kde.org/r/126343/diff/


Testing
-------

Tests pass, used by KAboutApplicationDialog in okular: https://git.reviewboard.kde.org/r/126193/


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151228/995d045e/attachment.html>