Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

David Edmundson david at davidedmundson.co.uk
Mon Dec 28 14:20:15 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126474/
-----------------------------------------------------------

(Updated Dec. 28, 2015, 2:20 p.m.)


Review request for KDE Frameworks.


Changes
-------

Added exciting comment


Repository: kio


Description
-------

A static QRegExp was used but it is not thread safe. QRegularExpression
seems to be.

BUG: 352356


Diffs (updated)
-----

  src/urifilters/shorturi/kshorturifilter.cpp 6002ec6925c0acdd20a053f98baca46863f69fa6 

Diff: https://git.reviewboard.kde.org/r/126474/diff/


Testing
-------

I ran the autotests which includes urifilter and I've run krunner which uses it extensively.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151228/ef4469b2/attachment.html>


More information about the Kde-frameworks-devel mailing list