Review Request 126531: Fix some Clazy warnings in kemoticons.

[Andrey Cygankov]

> On Дек. 27, 2015, 5:53 п.п., Aleix Pol Gonzalez wrote:
> > src/providers/pidgin/pidgin_emoticons.cpp, line 180
> > <https://git.reviewboard.kde.org/r/126531/diff/1/?file=426114#file426114line180>
> >
> >     Use QLatin1String when comparing, same for the next one.

How to understand:
/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp:179:13: warning: QString(const char*) being called [-Wclazy-qstring-uneeded-heap-allocations]
        if (splitted.at(0) == "!") {
            ^


> On Дек. 27, 2015, 5:53 п.п., Aleix Pol Gonzalez wrote:
> > src/providers/adium/adium_emoticons.cpp, line 51
> > <https://git.reviewboard.kde.org/r/126531/diff/1/?file=426112#file426112line51>
> >
> >     Comparison wants QLatin1String() as it has the overload.

How to understand:
/kemoticons/src/providers/adium/adium_emoticons.cpp:51:35: warning: QString(const char*) being called [-Wclazy-qstring-uneeded-heap-allocations]
            if (!dict.isNull() && dict.tagName() == "dict") {
                                  ^


- Andrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126531/#review90163
-----------------------------------------------------------


On Дек. 27, 2015, 5:50 п.п., Andrey Cygankov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126531/
> -----------------------------------------------------------
> 
> (Updated Дек. 27, 2015, 5:50 п.п.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> -------
> 
> Fix some Clazy warnings:
> - unneeded heap allocation with QString
> - multi-arg non-usage
> 
> 
> Diffs
> -----
> 
>   autotests/kemoticontest.cpp df7fb71 
>   autotests/ktexttohtmlplugintest.cpp 0daa222 
>   src/core/kemoticons.cpp 886cc3f 
>   src/providers/adium/adium_emoticons.cpp 31535ab 
>   src/providers/kde/kde_emoticons.cpp 2723e00 
>   src/providers/pidgin/pidgin_emoticons.cpp 92398c4 
>   src/providers/xmpp/xmpp_emoticons.cpp af71ef9 
>   tests/main.cpp d1eab5b 
> 
> Diff: https://git.reviewboard.kde.org/r/126531/diff/
> 
> 
> Testing
> -------
> 
> Compiling without errors.
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151227/9398084c/attachment.html>