Review Request 126392: Fix some Clazy warnings in kcoreaddons

Andrey Cygankov craftplace.ms at gmail.com
Fri Dec 25 22:48:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126392/
-----------------------------------------------------------

(Updated Дек. 25, 2015, 10:48 п.п.)


Review request for KDE Frameworks and Aleix Pol Gonzalez.


Changes
-------

fix issue += and toLocal8Bit()


Repository: kcoreaddons


Description
-------

Fix some Clazy warnings:
- unneeded heap allocation with QString
- midRef() non-usage
- isEmpty() non-usage


Diffs (updated)
-----

  autotests/ktexttohtmltest.cpp 81c3fc0 
  src/lib/io/kbackup.h ead2de5 
  src/lib/io/kbackup.cpp ec8b8b2 
  src/lib/io/kdirwatch.cpp 34b32b7 
  src/lib/io/kdirwatch_p.h 4483961 
  src/lib/io/kmessage.cpp 305318c 
  src/lib/io/kprocess.cpp 1df61c0 
  src/lib/io/kurlmimedata.cpp 4095ee1 
  src/lib/kaboutdata.h 0dbd7a0 
  src/lib/kaboutdata.cpp 5d9a55e 
  src/lib/randomness/krandom.cpp 2eb80d2 
  src/lib/text/kmacroexpander.cpp 0d05ffd 
  src/lib/text/kstringhandler.cpp 826ddcb 
  src/lib/text/ktexttohtml.cpp d58f5c0 
  src/lib/util/kshell.cpp 11892ce 

Diff: https://git.reviewboard.kde.org/r/126392/diff/


Testing
-------

Compiling without errors


Thanks,

Andrey Cygankov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151225/a0fa384b/attachment.html>


More information about the Kde-frameworks-devel mailing list