Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90104
-----------------------------------------------------------


code looks fine.

Though please do the TODOs before merging as historically we have a have a habbit of them not getting done
Also your StatusNotifierItem leaks  - but it proably wants to be the lifespan of the application anyway.

- David Edmundson


On Dec. 25, 2015, 4:24 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2015, 4:24 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This adds a new "--passive" option to DrKonqi where it will only show a StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just dump the user on the home screen than telling him something went wrong, so he can just quickly start the app again instead of being annoyed by an error message". On iOS you also just get dropped on the home screen. Windows desktop shows a "Searching for a solution" dialog which was *the* major annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -----
> 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> -------
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black screen inbetween, just the panel restarting. Afterwards I got a SNI which opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151225/735e3bc6/attachment.html>