Review Request 126476: Make it possible to use doubles as index for i18np*() calls
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Dec 23 15:30:24 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126476/
-----------------------------------------------------------
(Updated Dec. 23, 2015, 3:30 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Chusslove Illich.
Changes
-------
Submitted with commit 27b24ea8d1925aec843ac337617a1b18469b8dfa by Aleix Pol to branch master.
Repository: ki18n
Description
-------
Also considers double values to check for plurals.
In QML it's hard to ensure a value is an integer and we'd get unreliable results, e.g. `i18nd("%1 thing", "%1 things", 3-i)`.
Also it creates a separate function to reuse some code.
Diffs
-----
autotests/ki18ndeclarativetest.cpp cf8e778
autotests/test.qml 314b516
src/klocalizedcontext.h c322e33
src/klocalizedcontext.cpp 3bc42dd
src/klocalizedstring.cpp 69950d2
Diff: https://git.reviewboard.kde.org/r/126476/diff/
Testing
-------
Added new tests, which now pass.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151223/deec4be4/attachment.html>
More information about the Kde-frameworks-devel
mailing list