Review Request 126400: [GCI] Fix some Clazy warnings

Imran Tatriev itatriev at gmail.com
Wed Dec 23 15:01:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126400/
-----------------------------------------------------------

(Updated Dec. 23, 2015, 4:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kconfig


Description
-------

I've fixed some warnings, here they are:

- Unneeded heap allocation with QString
- Detaching temporary
- Multi-arg non-usage
- isEmpty() non-usage
- midRef() non-usage
- "QVariant::toFoo() instead of QVariant::value<Foo>()" non-usage


Diffs
-----

  autotests/kconfig_compiler/kconfigcompiler_test.cpp 231e3c4 
  autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp 9a26ca1 
  src/core/kconfiggroup.cpp e09d602 
  src/core/kemailsettings.cpp 59d5f6e 
  src/gui/kconfiggroupgui.cpp b8d3089 
  src/kconf_update/kconf_update.cpp 9567c2d 
  src/kconf_update/kconfigutils.cpp 12b0749 
  src/kconfig_compiler/kconfig_compiler.cpp 91f6005 
  src/kreadconfig/kwriteconfig.cpp a852c28 

Diff: https://git.reviewboard.kde.org/r/126400/diff/


Testing
-------


Thanks,

Imran Tatriev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151223/55df7cb5/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list