Review Request 126476: Make it possible to use doubles as index for i18np*() calls

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126476/#review89999
-----------------------------------------------------------



src/klocalizedstring.cpp (line 1128)
<https://git.reviewboard.kde.org/r/126476/#comment61680>

    Missing std::abs.


- Chusslove Illich


On Дец. 23, 2015, 3:41 по п., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126476/
> -----------------------------------------------------------
> 
> (Updated Дец. 23, 2015, 3:41 по п.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Also considers double values to check for plurals.
> 
> In QML it's hard to ensure a value is an integer and we'd get unreliable results, e.g. `i18nd("%1 thing", "%1 things", 3-i)`.
> 
> Also it creates a separate function to reuse some code.
> 
> 
> Diffs
> -----
> 
>   autotests/ki18ndeclarativetest.cpp cf8e778 
>   autotests/test.qml 314b516 
>   src/klocalizedcontext.h c322e33 
>   src/klocalizedcontext.cpp 3bc42dd 
>   src/klocalizedstring.cpp 69950d2 
> 
> Diff: https://git.reviewboard.kde.org/r/126476/diff/
> 
> 
> Testing
> -------
> 
> Added new tests, which now pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151223/38687cb1/attachment.html>