Review Request 126440: Fix some Clazy warnings in kinit.
Andrey Cygankov
craftplace.ms at gmail.com
Wed Dec 23 14:50:24 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126440/
-----------------------------------------------------------
(Updated Dec. 23, 2015, 2:50 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
-------
Submitted with commit c0c8cd8bca239722d67e1d2e6d4c59ca50671d52 by Aleix Pol on behalf of Andrey Cygankov to branch master.
Repository: kinit
Description
-------
Fix some Clazy warnings in kinit:
- unneeded heap allocation with QString
- qEnvironmentVariableIsEmpty() non-usage
- isEmpty() non-usage
Diffs
-----
src/kdeinit/kinit.cpp a18008a
src/klauncher/klauncher.h e155f72
src/klauncher/klauncher.cpp 8b3d343
src/klauncher/klauncher_main.cpp 432e19a
src/wrapper.cpp 95b7ec2
Diff: https://git.reviewboard.kde.org/r/126440/diff/
Testing
-------
Compiling without errors.
Automated tests pass.
Thanks,
Andrey Cygankov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151223/3a32e6a7/attachment.html>
More information about the Kde-frameworks-devel
mailing list