Review Request 126476: Make it possible to use doubles as index for i18np*() calls

[Alexander Potashev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126476/#review89968
-----------------------------------------------------------


Test question: should it be "1.5 other windows" or "1.5 other window"?

The code in this patch seems to truncate the double to an integer and then use the appropriate plural form for the integer. But, for example, in Russian "5.4 billion" is read as "five and four tens of a billion" where instead of "of a billion" we actually put "billion" in genitive case. Thus for fractions the proper plural form will always be the same, independent of their values.

- Alexander Potashev


On Дек. 22, 2015, 9:57 п.п., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126476/
> -----------------------------------------------------------
> 
> (Updated Дек. 22, 2015, 9:57 п.п.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Also considers double values to check for plurals.
> 
> In QML it's hard to ensure a value is an integer and we'd get unreliable results, e.g. `i18nd("%1 thing", "%1 things", 3-i)`.
> 
> Also it creates a separate function to reuse some code.
> 
> 
> Diffs
> -----
> 
>   autotests/ki18ndeclarativetest.cpp cf8e778 
>   autotests/test.qml 314b516 
>   src/klocalizedstring.cpp 69950d2 
> 
> Diff: https://git.reviewboard.kde.org/r/126476/diff/
> 
> 
> Testing
> -------
> 
> Added new tests, which now pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151223/c908c061/attachment.html>